Can’t displayed checksum pattern

[ponkio-o]

aqua version

v2.4.1 and v2.4.0 both occured.

$ aqua -v
aqua version 2.4.1 (be0adf0c14ce53d285e57c3ed5f90dd5e19406cd)

$ aqua -v
aqua version 2.4.0 (b363157725c8e8b0bbc53b34782967a910eea45c)

v2.3.7 is works fine.

$ aqua -v
aqua version 2.3.7 (c07105b10ab825e7f309d2eb83278a0422a2b24f)

Environment

• OS: macOS Monterey
• CPU Architecture: amd64

Overview

I don't see the checksum file pattern that should appear when I run the aqua gr command.

How to reproduce

Executed command and output

$ aqua -v
aqua version 2.4.1 (be0adf0c14ce53d285e57c3ed5f90dd5e19406cd)

$ aqua gr Madh93/tpm

Debug output

$ AQUA_LOG_LEVEL=debug aqua gr Madh93/tpm
DEBU[0000] got the release                               aqua_version=2.4.1 env=darwin/amd64 program=aqua version=v0.3.0
DEBU[0000] got assets                                    aqua_version=2.4.1 env=darwin/amd64 num_of_assets=9 program=aqua
DEBU[0000] exclude an asset                              aqua_version=2.4.1 asset_name=tpm_Linux_i386.tar.gz env=darwin/amd64 program=aqua
DEBU[0000] exclude an asset                              aqua_version=2.4.1 asset_name=tpm_Windows_i386.zip env=darwin/amd64 program=aqua
packages:
  - type: github_release
    repo_owner: Madh93
    repo_name: tpm
    description: A package manager for Terraform providers
    asset: tpm_{{.OS}}_{{.Arch}}.{{.Format}}
    format: tar.gz
    overrides:
      - goos: windows
        format: zip
    replacements:
      amd64: x86_64
      darwin: Darwin
      linux: Linux
      windows: Windows
    checksum:
      type: github_release
      asset: checksums.txt
      algorithm: sha256

Expected behaviour

Originally, should displayed as following.

$ aqua gr Madh93/tpm
packages:
  - type: github_release
    repo_owner: Madh93
    repo_name: tpm
    description: A package manager for Terraform providers
    asset: tpm_{{.OS}}_{{.Arch}}.{{.Format}}
    format: tar.gz
    overrides:
      - goos: windows
        format: zip
    replacements:
      amd64: x86_64
      darwin: Darwin
      linux: Linux
      windows: Windows
    checksum:
      type: github_release
      asset: checksums.txt
      file_format: regexp
      algorithm: sha256
      pattern:
        checksum: "^(\\b[A-Fa-f0-9]{64}\\b)"
        file: "^\\b[A-Fa-f0-9]{64}\\b\\s+(\\S+)$"

Actual behaviour

Executed result hasn't packages[].checksum.pattern.

$ aqua gr Madh93/tpm
packages:
  - type: github_release
    repo_owner: Madh93
    repo_name: tpm
    description: A package manager for Terraform providers
    asset: tpm_{{.OS}}_{{.Arch}}.{{.Format}}
    format: tar.gz
    overrides:
      - goos: windows
        format: zip
    replacements:
      amd64: x86_64
      darwin: Darwin
      linux: Linux
      windows: Windows
    checksum:
      type: github_release
      asset: checksums.txt
      algorithm: sha256

Important Factoids

None

Reference

None

[suzuki-shunsuke]

This is not a bug.

From v1.37.0, aqua supports the default checksum parser. #1577 #1762

Please see #1577 (comment)

And from aqua v2.4.0, aqua gr uses the default checksum parser.

https://github.com/aquaproj/aqua/releases/tag/v2.4.0

#1914 generate-registry: Use the default checksum parser
⚠️ Default checksum parser requires aqua >= v1.37.0

[suzuki-shunsuke]

FYI. I'll update aqua-registry to use the default checksum parser soon.

• feat: convert the checksum parser o default checksum parser aqua-registry#11836

[ponkio-o]

Thank you for you reply quickly and sorry missed 🙏
I understand new feature and why needed.