Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serbian translations (strings and categories) #9857

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

dobridabar
Copy link
Contributor

Scope of this PR:

  1. All strings in data/strings/strings.txt (Serbian cyrillic only)
  2. Most categories in data/categories.txt (Serbian cyrillic and latin)

All strings in data/strings/strings.txt are translated to Serbian (this covers most of the UI strings). Serbian uses both cyrillic and latin alphabets. Some Android phones offer Serbian (cyrillic) language setting, some offer Serbian (latin) language setting, and some offer both.

I only provided cyrillic strings in strings.txt file. My testing showed that if an Android user selects Serbian (cyrillic) language setting, then those strings will be displayed as-is. If a user selects Serbian (latin) language setting, then Android will automatically convert Serbian cyrillic into latin for all UI labels. Therefore, it seems that it is not necessary to provide Serbian latin translations for Android in strings.txt.

I didn't have a chance to test with iPhone, so I don't know the exact behavior for that platform.

If in the future we decide that we also need Serbian latin translations, they can be generated automatically from cyrillic counterparts.

Most categories in data/categories.txt are translated to Serbian. I used both cyrillic and latin, because categories represent the user input, and people in Serbia use different keyboard settings: some of them use only cyrillic, some of them use only latin, and some use both. Because there is not automatic transcription of cyrillic input into latin, we need to state both cyrillic and latin category names.

The remaining translations will be a subject of a future PRs.

@pastk
Copy link
Member

pastk commented Dec 11, 2024

Will need to enable Serbian language in categories.txt first like in 35613f8

@pastk pastk requested a review from a team December 11, 2024 18:22
@dobridabar
Copy link
Contributor Author

@pastk, I added Serbian to android/app/src/main/res/xml/locales_config.xml and to indexer/categories_holder.hpp, and regenerated.

@dobridabar
Copy link
Contributor Author

It seems that I accidentally change a single Marathi translation in categories.txt. I just did another force push to undo that change.

@pastk
Copy link
Member

pastk commented Dec 12, 2024

FYI @biodranik

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

I'll check iOS. The next step is to translate types_strings.txt

@biodranik biodranik merged commit 3505356 into organicmaps:master Dec 14, 2024
16 checks passed
@ZeljkoBG
Copy link

@biodranik
I announced that I was translating types_strings.txt for the Serbian language. Don't let me and someone else translate so that it becomes a wasted job. That I worked for nothing.

@biodranik
Copy link
Member

@ZeljkoBG this is very good news! Please continue if you already started it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants