-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serbian translations (strings and categories) #9857
Conversation
Will need to enable Serbian language in categories.txt first like in 35613f8 |
3ac0753
to
49c0de7
Compare
@pastk, I added Serbian to android/app/src/main/res/xml/locales_config.xml and to indexer/categories_holder.hpp, and regenerated. |
Signed-off-by: Ognjen Blagojevic <[email protected]>
Signed-off-by: Ognjen Blagojevic <[email protected]>
49c0de7
to
bd06f77
Compare
It seems that I accidentally change a single Marathi translation in categories.txt. I just did another force push to undo that change. |
FYI @biodranik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution!
I'll check iOS. The next step is to translate types_strings.txt
@biodranik |
@ZeljkoBG this is very good news! Please continue if you already started it. |
Scope of this PR:
All strings in data/strings/strings.txt are translated to Serbian (this covers most of the UI strings). Serbian uses both cyrillic and latin alphabets. Some Android phones offer Serbian (cyrillic) language setting, some offer Serbian (latin) language setting, and some offer both.
I only provided cyrillic strings in strings.txt file. My testing showed that if an Android user selects Serbian (cyrillic) language setting, then those strings will be displayed as-is. If a user selects Serbian (latin) language setting, then Android will automatically convert Serbian cyrillic into latin for all UI labels. Therefore, it seems that it is not necessary to provide Serbian latin translations for Android in strings.txt.
I didn't have a chance to test with iPhone, so I don't know the exact behavior for that platform.
If in the future we decide that we also need Serbian latin translations, they can be generated automatically from cyrillic counterparts.
Most categories in data/categories.txt are translated to Serbian. I used both cyrillic and latin, because categories represent the user input, and people in Serbia use different keyboard settings: some of them use only cyrillic, some of them use only latin, and some use both. Because there is not automatic transcription of cyrillic input into latin, we need to state both cyrillic and latin category names.
The remaining translations will be a subject of a future PRs.