Title background #2
Conversation
src/getColor.ts
Outdated
| } | ||
|
|
||
| const getConfig = () => { | ||
| export const getSetting = (value: string) => { |
There was a problem hiding this comment.
the filename getColor doesn't fit anymore once you've exported getSetting
Maybe move this to a new settings.ts file
README.md
Outdated
| For example: | ||
|
|
||
| ``` | ||
| // To settings.json => workspace settings. Defaults to the last color (.* is a wildcard). |
There was a problem hiding this comment.
Not sure I would put this as the example. If you're trying to say that the last regex wins, we can write that without an example IMO.
However writing a small example is a good idea
|
@Qantt Just made a few small remarks |
|
Hi, thanks for the remarks. I am going to take a look at this when I get off work. It's morning here so it's going to take a while though. |
|
Updated based on your PR review, good catches! It should be noted that in vscode extension development mode the title background color does not change, but it works fine when installing from vsix. 🚀 |
|
Approved |
I am working with a quite large monorepo and this tool would help me a lot. I added an ability to color title background. It works the same way as tab coloring (based on the current user location). Title background coloring makes it even more easy to deduct current location in the project.