More components coloring options #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good
I'll handle the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (closes #9) adds the ability to change the color of both the activity and status bar.
It uses the same single color that's being set in the extensions' settings.
I didn't add the ability to change the sidebar color because it's a bit more complexed of a component than the rest, having selected states for some nested items (e.g. headers and current selected file in the explorer) and multiple font colors so it doesn't look as nice when only changing 1 color.
I also made a minor code style refactor in
changeColors.ts- destructuring the settings object since it became pretty long, I added it in a separate commit so it's easier to review and in case you prefer to revert that change.One more necessary change that's not currently included in the PR but I can add if you want is the relevant changes to the readme, I wasn't sure if you want to handle that or not.