Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minor): Add signposts for explicit starts #260

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Aug 13, 2024

Description

Adding support for per-iteration signposts as requested in
#259

How Has This Been Tested?

Manually verified.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.32%. Comparing base (f03eaa2) to head (69e56e4).

Files Patch % Lines
Sources/Benchmark/Benchmark.swift 80.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   65.30%   65.32%   +0.01%     
==========================================
  Files          33       33              
  Lines        3597     3610      +13     
==========================================
+ Hits         2349     2358       +9     
- Misses       1248     1252       +4     
Files Coverage Δ
Sources/Benchmark/BenchmarkExecutor.swift 90.73% <100.00%> (+0.28%) ⬆️
Sources/Benchmark/Benchmark.swift 66.98% <80.00%> (-2.63%) ⬇️
Files Coverage Δ
Sources/Benchmark/BenchmarkExecutor.swift 90.73% <100.00%> (+0.28%) ⬆️
Sources/Benchmark/Benchmark.swift 66.98% <80.00%> (-2.63%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03eaa2...69e56e4. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

@hassila hassila merged commit a214635 into main Aug 13, 2024
10 of 13 checks passed
@hassila hassila deleted the add-signposts-for-explicit-starts branch August 13, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants