feat: Make it possible to build and run without jemalloc available #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassila
requested review from
mr-swifter,
dimlio,
freef4ll,
GrockingCode and
ser-0xff
|
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2023-03-22T16:08:34+00:00 |
freef4ll
approved these changes
Mar 22, 2023
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dimlio
approved these changes
Mar 22, 2023
|
|
||
| if let disableJemalloc, disableJemalloc != "false", disableJemalloc != "0" { | ||
| package.targets += [ | ||
| .target( |
There was a problem hiding this comment.
Factor out common parts of this target?
There was a problem hiding this comment.
Will file issue for it and fix next time around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some platforms doesn't have jemalloc available and it'd be nice to be able to use benchmark without the malloc counters there.
Fixes #15
and
Fixes #60 (sort of)
To run test suite on macOS without crash you can now use:
BENCHMARK_DISABLE_JEMALLOC=1 swift testTo run benchmarks without jemalloc installed:
BENCHMARK_DISABLE_JEMALLOC=1 swift package benchmarkHow Has This Been Tested?
Manually tested with jemalloc installed/uninstalled.
Minimal checklist:
DocCcode-level documentation for any public interfaces exported by the package