Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that send addressess are valid for current network #698

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 23, 2022

Addresses encode the network that they are valid for. Check this, so that it's not possible to send to, for example, a signet address on mainnet.

@casey casey requested a review from raphjaph October 23, 2022 08:53
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is very important!

@casey casey enabled auto-merge (squash) October 24, 2022 16:56
@casey casey disabled auto-merge October 24, 2022 17:50
@casey casey merged commit bb8b71f into master Oct 24, 2022
@casey casey deleted the check-send-address-network branch October 24, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants