Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve transaction builder checks #661

Merged
merged 6 commits into from
Oct 17, 2022
Merged

Improve transaction builder checks #661

merged 6 commits into from
Oct 17, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Oct 17, 2022 •
edited
Loading

  • Add should-panic checks to ensure they're operating correctly
  • Add invariant messages to all expects and asserts
  • Refactor build checks to operate on the built transaction, instead of the builder. This seems better, since if we mess up transaction construction somehow, but the builder is okay, this would catch that case

@casey casey marked this pull request as ready for review October 17, 2022 00:54
@casey casey requested a review from raphjaph October 17, 2022 00:54
@casey casey merged commit 208ba95 into master Oct 17, 2022
@casey casey deleted the transaction-builder-checks branch October 17, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph