Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total child count #4009

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Show total child count #4009

merged 6 commits into from
Oct 26, 2024

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Oct 22, 2024

Add a child totalizer to the inscription page.

@casey
Copy link
Collaborator

casey commented Oct 24, 2024

We're discussing how to display the number of children on the /inscription page, and not coming to an obvious conclusion. Do you want this PR so that the number of children is displayed, or so that the number of children is returned from the API? If you don't care that the number of children is displayed on the /inscription page, we could remove that from this PR and worry about it later.

@arik-so
Copy link
Contributor Author

arik-so commented Oct 24, 2024

The motivation was primarily UX, giving users a sanity check for their child count if their inscription has many. Particularly considering that the JSON API is disabled on the main deployment, I think displaying the count is something worth keeping.

What's the biggest holdup? Localized number formatting (which should probably be done client-side if you're considering it), or does the parenthetical suffix feel like too much of an afterthought?

@casey
Copy link
Collaborator

casey commented Oct 24, 2024

Gotcha. We don't really like modifying the "children" <dt> So maybe it could go in the all link instead? I.e. all 4 or all 4 children.

@arik-so
Copy link
Contributor Author

arik-so commented Oct 24, 2024

Sure! As long as there's a counter somewhere on the page, I have 0 preferences which tag it's in.

@arik-so
Copy link
Contributor Author

arik-so commented Oct 24, 2024

Come to think of it though, it might be prudent for the /children page to also show the total somewhere.

@raphjaph
Copy link
Collaborator

Come to think of it though, it might be prudent for the /children page to also show the total somewhere.

That makes sense. Let's put it in a separate PR though

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph enabled auto-merge (squash) October 26, 2024 01:40
@raphjaph raphjaph merged commit d97cf03 into ordinals:master Oct 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants