-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show total child count #4009
Show total child count #4009
Conversation
We're discussing how to display the number of children on the /inscription page, and not coming to an obvious conclusion. Do you want this PR so that the number of children is displayed, or so that the number of children is returned from the API? If you don't care that the number of children is displayed on the /inscription page, we could remove that from this PR and worry about it later. |
The motivation was primarily UX, giving users a sanity check for their child count if their inscription has many. Particularly considering that the JSON API is disabled on the main deployment, I think displaying the count is something worth keeping. What's the biggest holdup? Localized number formatting (which should probably be done client-side if you're considering it), or does the parenthetical suffix feel like too much of an afterthought? |
Gotcha. We don't really like modifying the "children" |
Sure! As long as there's a counter somewhere on the page, I have 0 preferences which tag it's in. |
Come to think of it though, it might be prudent for the /children page to also show the total somewhere. |
That makes sense. Let's put it in a separate PR though |
7cd4623
to
10095b9
Compare
35d3e1c
to
1e785e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a child totalizer to the inscription page.