Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /address/:address/ JSON API endpoints #4008

Closed

Conversation

lifofifoX
Copy link
Collaborator

@lifofifoX lifofifoX commented Oct 21, 2024

This is branched off #3979

In addition to the /address/:address/cardinals endpoint, this PR adds /address/:address/runes and /address/:address/inscriptions endpoints.

This PR also groups all the /address/:address/* tests. That way, we don't need a dedicated test to check that inscriptions/runes are excluded from /address/:address/cardinals.

@lifofifoX
Copy link
Collaborator Author

@raphjaph Any thoughts on this?

lifofifoX added a commit to TheWizardsOfOrd/ord that referenced this pull request Nov 7, 2024
@raphjaph
Copy link
Collaborator

raphjaph commented Nov 8, 2024

I think we should go with something like this: #4056

What do you think?

@raphjaph
Copy link
Collaborator

raphjaph commented Nov 9, 2024

Closed by #4056

@raphjaph raphjaph closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants