Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview automatically mine blocks #2809

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Preview automatically mine blocks #2809

merged 10 commits into from
Dec 4, 2023

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Dec 3, 2023

Allows telling preview to mine blocks automatically every blocktime seconds. Mostly to test blockheight recursive endpoint changes.

@raphjaph raphjaph requested a review from casey December 4, 2023 00:17
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the existing test, otherwise lgtm.

src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Outdated Show resolved Hide resolved
src/subcommand/preview.rs Show resolved Hide resolved
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph enabled auto-merge (squash) December 4, 2023 19:24
@raphjaph raphjaph merged commit 06ac7ba into master Dec 4, 2023
6 checks passed
@raphjaph raphjaph deleted the preview-mines-blocks branch December 4, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants