Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow splitting merged inscriptions #1927

Merged

Conversation

gmart7t2
Copy link
Contributor

I see a lot of users with multiple inscriptions merged into a single utxo.

Currently ord refuses to do anything with such utxos.

This pull request relaxes the condition on sending inscriptions and satpoints:

It is OK to send an inscription or satpoint from an output with multiple inscriptions in it as long as the satpoint being sent has no inscriptions after it, and also none within the dust limit before it.

As long as those conditions are met we can safely send the inscription or satpoint and the user can separate their merged inscriptions one by one, starting from the last in the output.

The error message when sending is not allowed has been modified to mention the last inscription in the output rather than the first to help guide the user to the one they need to send first.

Greg Martin added 2 commits March 13, 2023 14:03
We can safely send the last inscription from an output that contains
multiple inscriptions.

Iterate through the inscriptions in reverse order so that when
attempting to send an inscription that isn't the last one in its
output, the error message produced mentions the last inscription's
location and inscription identifier.
@gmart7t2
Copy link
Contributor Author

The lint failures go away after #1923.

@gmart7t2 gmart7t2 force-pushed the allow-splitting-merged-inscriptions branch 2 times, most recently from 2386a4c to 7f921fb Compare April 14, 2023 22:02
@raphjaph raphjaph enabled auto-merge (squash) August 22, 2023 22:57
@raphjaph raphjaph merged commit 68a41f7 into ordinals:master Aug 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants