Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complain when a satpoint's offset is off the end of the output. #1857

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

gmart7t2
Copy link
Contributor

When giving wallet send or wallet inscribe a satpoint with an invalid offset, ord crashes.

This fixes that.

Before:

$ ord wallet send --fee-rate 1 $addr $txid:0:9999999
thread 'main' panicked at 'Amount subtraction error', ~/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoin-0.29.2/src/util/amount.rs:722:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

After:

$ ord wallet send --fee-rate 1 $addr $txid:0:9999999
error: outgoing satpoint $txid:0:9999999 offset higher than maximum 1999

@raphjaph raphjaph enabled auto-merge (squash) March 7, 2023 02:57
@raphjaph raphjaph merged commit 98d01be into ordinals:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants