-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default for parameter --fee-rate
for wallet send
#1755
Conversation
This looks good to me -- I think we should also make Also we should update the guide to use |
Updated the guide, thanks @RarePepeMaximalist for the pointer. Update for |
Please include in your review this piece of code. If you are sending an amount of sats rather than an inscription, it will use an RPC command that does not take a I think this means that even if you require a |
Great point @droplister! This is actually the root problem behind #1432. So extremely nice find! |
Implement issue #1747
Given high fee environment many users run into issue with default fee rate of 1.
Review checklist:
--fee-rate
a mandatory argument forwallet send
#1747 that we need to also do this for wallet inscribe.)