Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansion of CONTRIBUTING #1698

Closed
wants to merge 3 commits into from
Closed

Expansion of CONTRIBUTING #1698

wants to merge 3 commits into from

Conversation

Psifour
Copy link
Contributor

@Psifour Psifour commented Feb 12, 2023

Still requires documentation for Translation/Localization efforts and a PR template.

Still requires documentation for Translation/Localization efforts and a PR template.
@raphjaph
Copy link
Collaborator

I'll convert to Draft since it's not ready for review yet

@raphjaph raphjaph marked this pull request as draft February 14, 2023 23:50
@Psifour
Copy link
Contributor Author

Psifour commented Feb 15, 2023

Absolutely should be a draft, I have no knowledge of any translation/localization being worked on currently and would love an assist if you know who is doing so (assuming it is being done).

I have a PR template (based on GitHub template) that I typically use, can be seen on #1669. If this is acceptable as a starting point I will include it in documentation for now.

@Psifour Psifour marked this pull request as ready for review March 6, 2023 21:09
@Psifour
Copy link
Contributor Author

Psifour commented Mar 6, 2023

Localization and PR templates were put in backlog. Documentation ready, but a proof-read or grammatical review would be appreciated.

Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this sit! This is great stuff, but the CONTRIBUTING file really functions as a legal disclaimer which informs contributors of the copyright status of their contributions, should they make them. I'd like to keep it short. Also, check out the contributing docs page, it might overlap with this. I think the right move here is to merge these changes into the contributing docs page.

@Psifour
Copy link
Contributor Author

Psifour commented Apr 10, 2023

That is a fair design decision. I personally avoid reading html-docs if I can find any of the standard file names I expect. These include LICENSE and CONTRIBUTING, but if the focus is to make the docs the primary focus then this should likely be closed.

@casey casey closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants