Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to transaction-list command to specify count #1049

Merged
merged 7 commits into from
Jan 2, 2023
Merged

add option to transaction-list command to specify count #1049

merged 7 commits into from
Jan 2, 2023

Conversation

rot13maxi
Copy link
Contributor

closes #1043

@casey
Copy link
Collaborator

casey commented Dec 23, 2022

What about calling this --limit instead? This could use a test, check out my comments on the other two PRs.

@casey
Copy link
Collaborator

casey commented Dec 23, 2022

Also, should the limit be unlimited instead?

@casey
Copy link
Collaborator

casey commented Dec 23, 2022

*default limit

@casey
Copy link
Collaborator

casey commented Jan 2, 2023

Just added some tests, and changes the flag to --limit. Take a look and let me know what you think! I want to get this in, because I think having an implicit limit of 10 is a bit odd.

@casey casey requested a review from raphjaph January 2, 2023 03:26
@casey casey merged commit 92e1528 into ordinals:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph Awaiting requested review from raphjaph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flag to list all txs (or larger set of txs) in terminal
2 participants
@rot13maxi @casey