-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django 2 support and update other dependencies. #44
base: master
Are you sure you want to change the base?
Conversation
The `on_delete` kwarg was added and the import syntax of `reverse` was changed in all found locations.
Also adds two new dev dependencies for convenience.
Add Django 2 support
The CI jobs are all failing due to supporting Django 1.9 and lower. I'm not sure how to add this feature while still retaining backwards compatibility for these versions of Django, so if the maintainers of this repository are still active, it's up to them whether it's worth deprecating and removing Django versions 1.8 and 1.9. |
going to fix failing tests next
…ay_data when appropriate.
…enter/django-fitbit into intraday-support-redo
@kblicharski Has the source branch for this PR been removed? I would like to fetch it and merge locally since the PR doesn't seem to be going into this repo. |
Ah never mind, just noticed that the account was not @kblicharski , but rather @thesignalcenter |
@rahul003 You're right, this PR will not be merged in. We will add 2.0 support without all the other extra changes this PR includes |
Changes
django.core.urlresolvers import reverse
becamefrom django.urls import reverse
user.is_authenticated()
becameuser.is_authenticated
MIDDLEWARE_CLASSES
becameMIDDLEWARE
on_delete
kwarg was added to all ForeignKeys/OneToOneFields/etcI also added
pip-review
andpipdeptree
as dev dependencies and reformatted the code to remove unused imports and add/remove newlines as needed.