Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 2 support and update other dependencies. #44

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

kblicharski
Copy link

@kblicharski kblicharski commented Jan 10, 2018

Changes

  • django.core.urlresolvers import reverse became from django.urls import reverse
  • user.is_authenticated() became user.is_authenticated
  • MIDDLEWARE_CLASSES became MIDDLEWARE
  • on_delete kwarg was added to all ForeignKeys/OneToOneFields/etc
  • All dependencies were updated to their most recent versions

I also added pip-review and pipdeptree as dev dependencies and reformatted the code to remove unused imports and add/remove newlines as needed.

@coveralls
Copy link

coveralls commented Jan 10, 2018

Coverage Status

Coverage decreased (-8.9%) to 88.571% when pulling 3e79f7a on thesignalcenter:master into 8928bc9 on orcasgit:master.

@kblicharski
Copy link
Author

The CI jobs are all failing due to supporting Django 1.9 and lower. I'm not sure how to add this feature while still retaining backwards compatibility for these versions of Django, so if the maintainers of this repository are still active, it's up to them whether it's worth deprecating and removing Django versions 1.8 and 1.9.

@rahul003
Copy link

rahul003 commented Oct 2, 2018

@kblicharski Has the source branch for this PR been removed? I would like to fetch it and merge locally since the PR doesn't seem to be going into this repo.

@rahul003
Copy link

rahul003 commented Oct 2, 2018

Ah never mind, just noticed that the account was not @kblicharski , but rather @thesignalcenter

@brad
Copy link
Member

brad commented Oct 4, 2018

@rahul003 You're right, this PR will not be merged in. We will add 2.0 support without all the other extra changes this PR includes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants