Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of missing checks for mgmt file provider #1582

Closed
noambergIL opened this issue Jul 7, 2020 · 0 comments · Fixed by #1590
Closed

A couple of missing checks for mgmt file provider #1582

noambergIL opened this issue Jul 7, 2020 · 0 comments · Fixed by #1590
Assignees
@noambergIL
Labels
Performance\optimisation

Comments

@noambergIL
Copy link
Contributor

noambergIL commented Jul 7, 2020 •
edited
Loading

when management file is parsed it should be checked for simple rules :
Historic response (timestamp given):
start <= end <= current

Latest response (no timestamp given):
start <= end = current

In Committess check that weight is not 0

(will fail if first time of node, but will also keep working in regular node)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noambergIL noambergIL

Labels
Performance\optimisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing checks in file provider of weights and current ref time orbs-network/orbs-network-go
1 participant
@noambergIL