Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to scalajs-dom 2.8.0 or newer #5049

Closed
ebruchez opened this issue Nov 5, 2021 · 10 comments
Closed

Update to scalajs-dom 2.8.0 or newer #5049

ebruchez opened this issue Nov 5, 2021 · 10 comments
Assignees

Comments

@ebruchez
Copy link
Collaborator

ebruchez commented Nov 5, 2021

No description provided.

@ebruchez ebruchez self-assigned this Nov 5, 2021
@ebruchez ebruchez changed the title Update to sjs-dom 2.0.0 Update to scalajs-dom 2.0.0 Nov 5, 2021
@ebruchez
Copy link
Collaborator Author

ebruchez commented Nov 6, 2021

Tried this but there is an issue: scalajs-jquery is not compiled against 2.0.0 so this doesn't compile. Specifically, JQueryEventObject causes problems. We'll need scalajs-jquery (or other) compiled against 2.0.0.

Work in progress on local wip-5049-scalajs-dom-20 branch.

@ebruchez
Copy link
Collaborator Author

ebruchez commented Nov 6, 2021

The scalajs-jquery we use (https://github.com/sjrd/scala-js-jquery/commits/master) is not really maintained anymore, and not even linked from the Scala.js site. Instead:

@ebruchez
Copy link
Collaborator Author

See also #5433.

@ebruchez
Copy link
Collaborator Author

Not sure about the Udash version now as it hasn't been updated in a year.

@ebruchez ebruchez changed the title Update to scalajs-dom 2.0.0 Update to scalajs-dom 2.8.0 or newer Nov 16, 2023
@ebruchez
Copy link
Collaborator Author

There have been two releases in 2023: 3.2.0 and 3.3.0. JQuery doesn't change often and we are reducing our dependence on it anyway, so hopefully this should be fine.

@avernet
Copy link
Collaborator

avernet commented May 30, 2024

+1 from me, to use HTMLDialogElement, already added in 2.3 (released in August 2022).

@ebruchez
Copy link
Collaborator Author

+1 again

@avernet
Copy link
Collaborator

avernet commented Oct 18, 2024

I’ve started looking into this. Let’s see where it takes us! :)

@avernet avernet assigned avernet and unassigned ebruchez Oct 18, 2024
@avernet
Copy link
Collaborator

avernet commented Oct 19, 2024

  • Test tooltip for radios/checkboxes
  • Test Fancy tree, in particular the listener on fancytreeactivate: try adding to Form Builder
  • Test Events.change is still called now that we use the DOM API to register that listener
  • Test clicking on UI elements of the JavaScript error dialog

@avernet
Copy link
Collaborator

avernet commented Oct 29, 2024

The Select2 library does not emit standard DOM change events (see select2/select2#1908) and instead only emits jQuery change events. Therefore, we will need to catch the jQuery event within our XBL component and dispatch a corresponding DOM event for InitSupport.scala.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants