-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add snap for ubuntu #965
Conversation
Signed-off-by: Samir Akarioh <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #965 +/- ##
=======================================
Coverage 81.15% 81.15%
=======================================
Files 53 53
Lines 2776 2776
=======================================
Hits 2253 2253
Misses 354 354
Partials 169 169 |
Co-authored-by: Terry Howe <[email protected]> Signed-off-by: SamirPS <[email protected]>
Co-authored-by: Terry Howe <[email protected]> Signed-off-by: SamirPS <[email protected]>
Signed-off-by: SamirPS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @SamirPS for contributing. Should |
@qweeah you can use theses actions to build and publish : https://github.com/snapcore/action-build and https://github.com/snapcore/action-publish |
Signed-off-by: SamirPS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you help format the header as suggested, thanks
Another stupid question on the versioning: I followed the instructed steps and the snapcraft ends with generating a file named |
Co-authored-by: Billy Zha <[email protected]> Signed-off-by: SamirPS <[email protected]>
It's not the version of oras it's come from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SamirPS Ready to be merged? |
Not for now @shizhMSFT we have a little issue when registering the name oras with @FeynmanZhou |
@shizhMSFT the MP can be merged now |
@SamirPS The DCO check failed. Could you fix that? |
yes i will do it |
Please wait for a while. I tested
|
@FeynmanZhou now i use the tag and pinpoint the version on the snapcraft.yaml file
|
Signed-off-by: Samir Akarioh <[email protected]>
Signed-off-by: SamirPS <[email protected]>
This snapcraft build snap for amd64,arm64 and s390x |
Signed-off-by: Samir Akarioh <[email protected]> Signed-off-by: SamirPS <[email protected]> Co-authored-by: Terry Howe <[email protected]> Co-authored-by: Billy Zha <[email protected]>
What this PR does / why we need it:
This PR permit to create a snap for ubuntu.
On Linux install snapcraft
git clone this repository and put the snapcraft.yaml file i put on the PR in this folder.
And After
AT the end you will have a .Snap file install it with
You have installed the snap, now just run oras by typing oras
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: