Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use oras-credential-go to do auth #932

Merged
merged 7 commits into from
Apr 27, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Apr 24, 2023

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #931

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@qweeah qweeah marked this pull request as draft April 24, 2023 09:21
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #932 (97871d1) into main (07fbec8) will increase coverage by 0.71%.
The diff coverage is 92.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   80.30%   81.01%   +0.71%     
==========================================
  Files          53       53              
  Lines        2853     2776      -77     
==========================================
- Hits         2291     2249      -42     
+ Misses        383      358      -25     
+ Partials      179      169      -10     
Impacted Files Coverage Δ
cmd/oras/root/login.go 72.22% <66.66%> (+4.18%) ⬆️
cmd/oras/internal/option/remote.go 79.00% <100.00%> (+2.28%) ⬆️
cmd/oras/root/logout.go 77.77% <100.00%> (+6.81%) ⬆️
internal/credential/store.go 78.57% <100.00%> (+7.73%) ⬆️

... and 1 file with indirect coverage changes

Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah marked this pull request as ready for review April 24, 2023 09:52
qweeah added 3 commits April 24, 2023 18:58
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/oras/root/login.go Outdated Show resolved Hide resolved
internal/credential/store.go Outdated Show resolved Hide resolved
internal/credential/store.go Outdated Show resolved Hide resolved
internal/credential/store.go Show resolved Hide resolved
cmd/oras/root/login.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <[email protected]>
internal/credential/store.go Outdated Show resolved Hide resolved
internal/credential/store.go Outdated Show resolved Hide resolved
internal/credential/store.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <[email protected]>
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go.sum Show resolved Hide resolved
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a54a99d into oras-project:main Apr 27, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrated with oras-credential-go
5 participants