Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make target for e2e #924

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Add make target for e2e #924

merged 1 commit into from
Apr 11, 2023

Conversation

sajayantony
Copy link
Contributor

Make doesn't have e2e. Potentially update the gitworkflow also use the make target instead of the run bash.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #924 (5aecbb8) into main (a7e690e) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   80.09%   80.09%           
=======================================
  Files          53       53           
  Lines        2853     2853           
=======================================
  Hits         2285     2285           
  Misses        388      388           
  Partials      180      180           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sajay Antony <[email protected]>
@qweeah
Copy link
Contributor

qweeah commented Apr 11, 2023

Just notice that we need to move e2e coverage generation out of the script e2e.sh, otherwise the E2E call stack would be Makefile(teste2e) -> E2E tests - > Makefile(e2e-covdata), which is weird. I can take on that.

@sajayantony sajayantony merged commit 9d7edb9 into oras-project:main Apr 11, 2023
@sajayantony sajayantony deleted the e2e branch April 11, 2023 05:52
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants