Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Logger initializes logging #867

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partial #786

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov-commenter
Copy link

Codecov Report

Merging #867 (a8c77c3) into main (e539375) will increase coverage by 0.78%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   66.39%   67.17%   +0.78%     
==========================================
  Files          21       21              
  Lines         860      850      -10     
==========================================
  Hits          571      571              
+ Misses        243      233      -10     
  Partials       46       46              
Impacted Files Coverage Δ
cmd/oras/internal/option/common.go 100.00% <ø> (+76.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

internal/trace/context.go Show resolved Hide resolved
internal/trace/context.go Show resolved Hide resolved
@qweeah qweeah added this to the v1.1.0 milestone Mar 12, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/trace/context.go Outdated Show resolved Hide resolved
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after cutting off 1.0.0 release branch.

Terry Howe and others added 2 commits March 21, 2023 08:52
@qweeah qweeah force-pushed the initialize-logging branch from 309561f to c8f86c4 Compare March 21, 2023 00:52
@qweeah qweeah merged commit 660d167 into oras-project:main Mar 21, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants