feat: add compatibility mode for push and attach cmd #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 73.46% 70.12% -3.34%
==========================================
Files 17 18 +1
Lines 588 616 +28
==========================================
Hits 432 432
- Misses 125 153 +28
Partials 31 31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
reviewed
Jan 12, 2023
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
reviewed
Jan 12, 2023
cmd/oras/push.go
Outdated
Comment on lines
107
to
109
| if opts.ManifestMediaType == ocispec.MediaTypeArtifactManifest && opts.manifestConfigRef != "" { | ||
| return errors.New("cannot pack an OCI artifact with manifest config at the same time") | ||
| } |
There was a problem hiding this comment.
It reminds me that there will be a feature request eventually to support --config for oras attach.
There was a problem hiding this comment.
Why? The content of config doesn't matter and the media type of config can be deducted from artifact type.
There was a problem hiding this comment.
If they could, they will ask.
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
reviewed
Jan 12, 2023
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
This reverts commit 4b13256. Signed-off-by: Billy Zha <[email protected]>
FeynmanZhou
reviewed
Jan 12, 2023
cmd/oras/attach.go
Outdated
| @@ -51,6 +53,14 @@ func attachCmd() *cobra.Command { | |||
| Example - Attach file 'hi.txt' with type 'doc/example' to manifest 'hello:test' in registry 'localhost:5000' | |||
| oras attach --artifact-type doc/example localhost:5000/hello:test hi.txt | |||
|
|
|||
| Example - Attach file "hi.txt" with specific manifest type for packing | |||
There was a problem hiding this comment.
I would suggest always splitting the sample commands into multiple examples. If you have more than two options under a flag and put all of those sample commands under a flag example, the layout looks too verbose.
Signed-off-by: Billy Zha <[email protected]>
FeynmanZhou
reviewed
Jan 13, 2023
FeynmanZhou
reviewed
Jan 13, 2023
Signed-off-by: Billy Zha <[email protected]>
1 task
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Resolves oras-project#739 Signed-off-by: Billy Zha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #739