fix: add log when failed to scan confirmation #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 72.12% 72.23% +0.10%
==========================================
Files 14 14
Lines 513 515 +2
==========================================
+ Hits 370 372 +2
Misses 114 114
Partials 29 29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shizhMSFT
reviewed
Nov 25, 2022
Comment on lines
46
to
55
| scanner := bufio.NewScanner(r) | ||
| if ok := scanner.Scan(); !ok { | ||
| return false, scanner.Err() | ||
| err := scanner.Err() | ||
| if err == nil { | ||
| // EOF | ||
| fmt.Println("Operation cancelled.") | ||
| } | ||
| return false, err | ||
| } | ||
| response := scanner.Text() |
There was a problem hiding this comment.
How about following the examples in the doc of bufio.Scanner?
var response string
scanner := bufio.NewScanner(r)
if ok := scanner.Scan(); ok {
response := scanner.Text()
}
if err := scanner.Err(); err != nil {
return false, err
}There was a problem hiding this comment.
Let me check if scanning EOF breaks strings.ToLower(response). If not, this is is definitely better.
Signed-off-by: Billy Zha <[email protected]>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Resolves oras-project#704 Signed-off-by: Billy Zha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #704
Signed-off-by: Billy Zha [email protected]