Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: fix colon in media type for windows #698

Merged
merged 39 commits into from
Dec 23, 2022
Merged

fix!: fix colon in media type for windows #698

merged 39 commits into from
Dec 23, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 21, 2022

Fixes #697
Signed-off-by: Billy Zha [email protected]

@qweeah qweeah marked this pull request as draft November 21, 2022 08:15
@qweeah qweeah changed the title fix: forbidden colon in media type [WIP] fix: forbidden colon in media type Nov 21, 2022
@qweeah
add unit tests
e2934c3 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
fix pull
975cbda 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
add GOOS
a78f0ff 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
fix failure
b8d759d 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah changed the title [WIP] fix: forbidden colon in media type fix: forbidden colon in media type Nov 21, 2022
@qweeah qweeah marked this pull request as ready for review November 21, 2022 09:02
@qweeah
fix windows test
b2731a0 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
remove CI change
9fff66b 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah changed the title fix: forbidden colon in media type fix!: forbidden colon in media type Nov 21, 2022
@qweeah
uncomment tests
afdd10e 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah changed the title fix!: forbidden colon in media type fix!: fix colon in media type for windows Nov 21, 2022
@qweeah qweeah requested review from shizhMSFT and Wwwsylvia and removed request for shizhMSFT November 21, 2022 14:26
@qweeah qweeah added the bug Something isn't working label Nov 23, 2022
@qweeah
update unit tests
6f779d8 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
unit test
98bb765 
Signed-off-by: Billy Zha <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022 •
edited
Loading

Codecov Report

Merging #698 (9d5e2be) into main (3ad6eee) will increase coverage by 0.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
+ Coverage   72.64%   73.17%   +0.52%     
==========================================
  Files          15       16       +1     
  Lines         563      574      +11     
==========================================
+ Hits          409      420      +11     
  Misses        123      123              
  Partials       31       31
Impacted Files Coverage Δ
cmd/oras/internal/fileref/unix.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qweeah
add tests
7420372 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah requested a review from Wwwsylvia November 23, 2022 08:45
@qweeah
add tests
6302404 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
more tests
50afb43 
Signed-off-by: Billy Zha <[email protected]>
Wwwsylvia
Wwwsylvia approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah self-assigned this Nov 24, 2022
shizhMSFT
shizhMSFT reviewed Nov 25, 2022
View reviewed changes
cmd/oras/internal/argument/file_unix.go Outdated Show resolved Hide resolved
cmd/oras/internal/argument/file_windows.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Dec 22, 2022
View reviewed changes
cmd/oras/internal/fileref/unix.go Outdated Show resolved Hide resolved
cmd/oras/internal/fileref/windows_test.go Outdated Show resolved Hide resolved
cmd/oras/internal/fileref/windows_test.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Dec 23, 2022
View reviewed changes
cmd/oras/internal/fileref/windows.go Outdated Show resolved Hide resolved
cmd/oras/internal/fileref/windows.go Outdated Show resolved Hide resolved
cmd/oras/internal/fileref/windows_test.go Show resolved Hide resolved
cmd/oras/internal/fileref/windows.go Outdated Show resolved Hide resolved
@qweeah qweeah requested a review from shizhMSFT December 23, 2022 08:43
@qweeah
add test
a32eb08 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
change test
6f1abcb 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
fix test
219e3cc 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
enhance unit tests
380b8f3 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
update unix
3804485 
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
shizhMSFT reviewed Dec 23, 2022
View reviewed changes
cmd/oras/internal/fileref/unix.go Outdated Show resolved Hide resolved
cmd/oras/internal/fileref/unix.go Outdated Show resolved Hide resolved
@qweeah
change tests
9e37975 
Signed-off-by: Billy Zha <[email protected]>
@qweeah
resolve comment
9d5e2be 
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah requested a review from shizhMSFT December 23, 2022 09:54
shizhMSFT
shizhMSFT approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 09e997a into oras-project:main Dec 23, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
@qweeah
fix!: fix colon in media type for windows (oras-project#698)
2fc3ee6 
Fixes oras-project#697 

Signed-off-by: Billy Zha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees

@qweeah qweeah

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oras push/attach should not allow colon in media type only on Windows
4 participants
@qweeah @codecov-commenter @Wwwsylvia @shizhMSFT