Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use short command for deletion & add alias for fetch config #675

Closed
wants to merge 3 commits into from

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 7, 2022

Resolves #667

Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #675 (7cb06e8) into main (690716b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          14       14           
  Lines         513      513           
=======================================
  Hits          370      370           
  Misses        114      114           
  Partials       29       29           
Impacted Files Coverage Δ
cmd/oras/internal/option/confirmation.go 85.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sajayantony
Copy link
Contributor

Glad that we have these aliases and it doesn't break anyone. Is there a work item for manifest get instead of manifest fetch to align with the renames?

@qweeah
Copy link
Contributor Author

qweeah commented Nov 8, 2022

Glad that we have these aliases and it doesn't break anyone. Is there a work item for manifest get instead of manifest fetch to align with the renames?

I am okay to replace oras manifest fetch with oras manifest get. cc @shizhMSFT @FeynmanZhou

@qweeah
Copy link
Contributor Author

qweeah commented Nov 8, 2022

Closing this PR since remove and delete means different things: delete means erase (i.e. rendered nonexistent or nonrecoverable), while remove denotes take away and set aside (but kept in existence).

Since user cannot undo oras manifest/blob delete via oras commands, we should avoid using remove in the example to avoid confusion. But it's okay to add it a alias, which is done in #677

@qweeah qweeah closed this Nov 8, 2022
@shizhMSFT
Copy link
Contributor

Glad that we have these aliases and it doesn't break anyone. Is there a work item for manifest get instead of manifest fetch to align with the renames?

Nope, the work item isn't there right now. The problem with the word get is to find out its opposites in terms of UX.

  • oras manifest get -- oras manifest set does not sound right.
  • oras manifest get -- oras manifest put sounds right but oras blob put is a bit strange since blobs are usually large.

For now, we have oras manifest fetch -- oras manifest push. The idea can be viewed similar to git fetch v.s. git pull where fetch will not change local filesystem but pull does. Anyway, we already have oras manifest get as an alias of oras manifest fetch. So... feel free to use oras manifest get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use shorter commands by default
4 participants