Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reorder status logs for oras pull #610

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Sep 22, 2022

Resolves #599

Signed-off-by: Billy Zha [email protected]

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this method does not sync with --debug option.

@wangxiaoxuan273
Copy link
Contributor

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #610 (b568e99) into main (5bef476) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          14       14           
  Lines         513      513           
=======================================
  Hits          370      370           
  Misses        114      114           
  Partials       29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qweeah qweeah changed the title fix: print skipped after predecessor downloaded fix: reorder status logs for oras pull Sep 23, 2022
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 7a8e5fd into oras-project:main Sep 23, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect order of the manifest downloading status
4 participants