Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add manifest fetch-config #540
feat: add manifest fetch-config #540
Changes from 5 commits
1bf788d
443fb5c
e5e7326
baf5928
ec29d6b
895dd31
ebd7de8
3bc296b
113d026
d2e2519
1e9370c
66229b4
98e2ee2
eb49aba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this flag as it does not have a user scenario and it confuses users? /cc @FeynmanZhou @yizha1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was tried to support the same feature as
oras pull --config
, but if users only use this command for an image manifest,--media-type
is not required, because we can always recognize the config for an image manifest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
--media-type
for now. I think if only image manifest type support thismanifest fetch-config
command, this argument is unnecessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we know it is an image manifest, we can call
oras.FetchBytes()
and then unmarshal it to extract the config descriptor. The simplified operation not only has less network calls but also cleaner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that
manifest fetch-config
is only used for image manifest? I see inoras pull --config
, users can provided the media type of the config file. If the manifest is not an image manifest, the command will fetch the blob who has a matched media type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
manifest fetch-config
should only run against image manifests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oras manifest fetch-config
should return error if the manifest is not an image manifest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved as required.