Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use read only target to replace oras.Target for the target storage with caching #538

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

lizMSFT
Copy link
Contributor

@lizMSFT lizMSFT commented Sep 7, 2022

Use oras.ReadOnlyTarget instead of oras.Target for the target storage with caching

Signed-off-by: Zoey Li [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #538 (539abca) into main (2bf9456) will decrease coverage by 1.90%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   73.26%   71.36%   -1.91%     
==========================================
  Files          11       11              
  Lines         419      419              
==========================================
- Hits          307      299       -8     
- Misses         89       98       +9     
+ Partials       23       22       -1     
Impacted Files Coverage Δ
internal/cache/target.go 60.86% <60.00%> (-11.60%) ⬇️
internal/cas/fetch.go 90.90% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 9ea7aee into oras-project:main Sep 7, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants