Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade oras-go #537

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

lizMSFT
Copy link
Contributor

@lizMSFT lizMSFT commented Sep 6, 2022

Bump oras-go from rc2 to latest code
Remove error message on platform mismatch in fetch.go since oras-project/oras-go#292 has already improve error message on platform mismatch in order to distinguish platform not found and manifest not found.

Signed-off-by: Zoey Li [email protected]

Signed-off-by: Zoey Li <[email protected]>
@yuehaoliang
Copy link
Contributor

Shall we change some usages of oras.Target to oras.ReadOnlyTarget in this PR? Like in pull.go.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 0010777 into oras-project:main Sep 6, 2022
@shizhMSFT
Copy link
Contributor

shizhMSFT commented Sep 6, 2022

Shall we change some usages of oras.Target to oras.ReadOnlyTarget in this PR? Like in pull.go.

It's OK to keep them since oras.Target is an oras.ReadOnlyTarget.

TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants