Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Descriptor and Pretty options for ORAS command #536

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

lizMSFT
Copy link
Contributor

@lizMSFT lizMSFT commented Sep 6, 2022

Add Descriptor and Pretty options for ORAS command so that these options could be used later in push/fetch/delete commands.

Signed-off-by: Zoey Li [email protected]

@lizMSFT lizMSFT marked this pull request as ready for review September 6, 2022 07:39
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #536 (c76022b) into main (0010777) will decrease coverage by 0.16%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   73.43%   73.26%   -0.17%     
==========================================
  Files           9       11       +2     
  Lines         399      419      +20     
==========================================
+ Hits          293      307      +14     
- Misses         85       89       +4     
- Partials       21       23       +2     
Impacted Files Coverage Δ
cmd/oras/internal/option/descriptor.go 62.50% <62.50%> (ø)
cmd/oras/internal/option/pretty.go 75.00% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT force-pushed the liz/addInternalOptions branch from ed707aa to c76022b Compare September 6, 2022 10:40
@shizhMSFT shizhMSFT merged commit 2bf9456 into oras-project:main Sep 6, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants