fix: print post-copy logs for unnamed content in verbose mode #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
=======================================
Coverage 72.68% 72.68%
=======================================
Files 9 9
Lines 388 388
=======================================
Hits 282 282
Misses 85 85
Partials 21 21 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qweeah
reviewed
Aug 19, 2022
…ipped or downloaded Signed-off-by: wangxiaoxuan273 <[email protected]>
|
After the fix, the verbose flag works properly.
|
Signed-off-by: wangxiaoxuan273 <[email protected]>
|
BTW, the title of this PR should be
|
wangxiaoxuan273
changed the title
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
…roject#511) Signed-off-by: wangxiaoxuan273 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verbose flag should work properly when unnamed content is skipped or downloaded. It currently does not. Example: this "downloading" is not paired with a "downloaded".
Part of issue #415
Signed-off-by: wangxiaoxuan273 [email protected]