Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to codecov.io #450

Merged
merged 20 commits into from
Jul 27, 2022
Merged

Migrate to codecov.io #450

merged 20 commits into from
Jul 27, 2022

Conversation

junczhu
Copy link
Contributor

@junczhu junczhu commented Jul 19, 2022

Fix: #441

Codecov Migrate Steps:

  • add coverage percent at .codecov

  • add codecov-action at build.yml

  • add badge at README.md

  • update make test with go test at makefile

  • update .gitignore / rmv .cover/ .test/ add coverage.txt

  • del shell/test.sh

  • del origin upload coverage report from build.yml

@junczhu junczhu changed the title Junczhu/codecov [WIP] Junczhu/codecov Jul 19, 2022
Signed-off-by: Juncheng Zhu <[email protected]>
@junczhu junczhu marked this pull request as ready for review July 19, 2022 07:45
@junczhu junczhu changed the title [WIP] Junczhu/codecov Junczhu/codecov Jul 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@60c143a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage        ?   55.69%           
=======================================
  Files           ?        6           
  Lines           ?      237           
  Branches        ?        0           
=======================================
  Hits            ?      132           
  Misses          ?       90           
  Partials        ?       15           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@junczhu junczhu changed the title Junczhu/codecov [WIP] Junczhu/codecov Jul 19, 2022
junczhu added 7 commits July 19, 2022 16:33
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
@junczhu junczhu changed the title [WIP] Junczhu/codecov Migrate to codecov.io Jul 22, 2022
@sajayantony
Copy link
Contributor

@junczhuMSFT might have to rebase this.
/cc @shizhMSFT @qweeah

@shizhMSFT
Copy link
Contributor

@junczhuMSFT You may also want to clean up previous coverage related scripts.

Makefile Outdated
@@ -19,7 +19,7 @@ LDFLAGS += -X $(PROJECT_PKG)/internal/version.GitTreeState=${GIT_DIRTY}

.PHONY: test
test: vendor check-encoding
./scripts/test.sh
go test -race -v -coverprofile=coverage.txt -covermode=atomic ./...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's extra space in the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's extra space in the code.

Extra space has been removed

Signed-off-by: Juncheng Zhu <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a976297 into oras-project:main Jul 27, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Migrate to codecov.io
4 participants