-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to codecov.io #450
Conversation
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage ? 55.69%
=======================================
Files ? 6
Lines ? 237
Branches ? 0
=======================================
Hits ? 132
Misses ? 90
Partials ? 15 Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
@junczhuMSFT might have to rebase this. |
@junczhuMSFT You may also want to clean up previous coverage related scripts. |
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Makefile
Outdated
@@ -19,7 +19,7 @@ LDFLAGS += -X $(PROJECT_PKG)/internal/version.GitTreeState=${GIT_DIRTY} | |||
|
|||
.PHONY: test | |||
test: vendor check-encoding | |||
./scripts/test.sh | |||
go test -race -v -coverprofile=coverage.txt -covermode=atomic ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's extra space in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's extra space in the code.
Extra space has been removed
Signed-off-by: Juncheng Zhu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Juncheng Zhu <[email protected]>
Fix: #441
Codecov Migrate Steps:
add coverage percent at .codecov
add codecov-action at build.yml
add badge at README.md
update make test with go test at makefile
update .gitignore / rmv .cover/ .test/ add coverage.txt
del shell/test.sh
del origin upload coverage report from build.yml