Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no tag or digest specified when pulling, return error #440

Merged
merged 9 commits into from
Jul 7, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jul 5, 2022

Related to #439, resolves #428

Signed-off-by: Billy Zha [email protected]

internal/errors/errors.go Outdated Show resolved Hide resolved
internal/errors/errors.go Outdated Show resolved Hide resolved
internal/errors/errors.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <[email protected]>
@qweeah qweeah requested a review from shizhMSFT July 6, 2022 02:07
internal/errors/errors.go Outdated Show resolved Hide resolved
qweeah added 2 commits July 7, 2022 13:47
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 209b945 into oras-project:main Jul 7, 2022
qweeah added a commit to qweeah/oras that referenced this pull request Jul 7, 2022
@qweeah qweeah deleted the fix-pull branch July 11, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty tag is not checked for oras pull
3 participants