Feat: minimal dep on containerd #312
Conversation
|
Sample output from oras from testing |
cmd/oras/push.go
Outdated
| // bake artifact | ||
| var pushOpts []oras.PushOpt | ||
| if opts.artifactType != "" { | ||
| refResolver := resolver | ||
| if iresolver.IsDummy(resolver) { | ||
| refResolver = newResolver(opts.username, opts.password, opts.insecure, opts.plainHTTP, opts.configs...) | ||
| refResolver, _ = newResolver(opts.username, opts.password, opts.insecure, opts.plainHTTP, opts.configs...) |
There was a problem hiding this comment.
Can we encapsulate this branching into the newResolver in resolve.go
There was a problem hiding this comment.
For this particular branch I can't because it would break --dry-run, but I can remove that call to newResolver
| "github.com/containerd/containerd/content" | ||
| "github.com/containerd/containerd/images" | ||
| "github.com/containerd/containerd/log" | ||
| "github.com/containerd/containerd/remotes" | ||
| orascontent "github.com/deislabs/oras/pkg/content" |
There was a problem hiding this comment.
I think we removed all deislabs referencs and should be under github.com/oras-project/oras/
There was a problem hiding this comment.
https://github.com/oras-project/oras/blob/artifacts/go.mod -- it's still desilabs in the artifacts branch
| @@ -2,6 +2,7 @@ package oras | |||
|
|
|||
There was a problem hiding this comment.
Given that this is a prototype branch I don't have concerns on this change. For the oras-go would like to ensure that discover has some tests.
There was a problem hiding this comment.
Actually I wrote tests already in oras-go so I can port them over here
| @@ -0,0 +1,266 @@ | |||
| package docker | |||
There was a problem hiding this comment.
What is the motivation of naming this docker? How about artifacts ?
There was a problem hiding this comment.
This serves a couple of purposes:
- to denote that this pkg is an extension/modification of remotes/docker in containerd
- maintainers know which folder to look at in containerd
- so that people who want to take a reference on this pkg know that it also depends on containerd/docker pkgs
In summary, it's analagous to naming this windows.go or linux.go to denote os, but here I'm denoting flavor.
|
Please fix DCO and let's get this merged - |
Signed-off-by: Sajay Antony <[email protected]> Signed-off-by: Julius Liu <[email protected]>
Signed-off-by: Sajay Antony <[email protected]> Signed-off-by: Julius Liu <[email protected]>
…#313) Signed-off-by: Sajay Antony <[email protected]> Signed-off-by: Julius Liu <[email protected]>
Signed-off-by: Julius Liu <[email protected]>
Signed-off-by: Julius Liu <[email protected]>
Bug: Fix host filtering Bug: Fix references Bug: Fix interface reference Signed-off-by: Julius Liu <[email protected]>
Signed-off-by: Julius Liu <[email protected]>
Signed-off-by: Julius Liu <[email protected]>
Signed-off-by: Julius Liu <[email protected]>
Signed-off-by: Julius Liu <[email protected]>
Feat: Adds fetching artifact manifests Bug: Fixes discover Signed-off-by: Julius Liu <[email protected]>
(confirmed tested that --dry-run still works) Signed-off-by: Julius Liu <[email protected]>
Signed-off-by: Julius Liu <[email protected]>
juliusl
force-pushed
the
juliusl/artifacts
branch
from
a405959 to
811dea6
Compare
|
@sajayantony done |
|
@sajayantony oops the license got deleted not sure why |
Signed-off-by: Julius Liu <[email protected]>
Does not require a dependency on oras-project/containerd, moved everything it needs to build over.
It compiles and runs, but I haven't tested discover yet, I need some help with that cc: @sajayantony
Give it a shot with: