-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oras discover with output tree format #297
Oras discover with output tree format #297
Conversation
Signed-off-by: Tejaswini Duggaraju <[email protected]>
Signed-off-by: Tejaswini Duggaraju <[email protected]>
1e964d1
to
c87e684
Compare
@SteveLasker please review |
Signed-off-by: Tejaswini Duggaraju <[email protected]>
3c40537
to
0ad5483
Compare
@@ -17,12 +17,13 @@ import ( | |||
ocispec "github.com/opencontainers/image-spec/specs-go/v1" | |||
"github.com/sirupsen/logrus" | |||
"github.com/spf13/cobra" | |||
"github.com/xlab/treeprint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently under MIT. Is that a concern or can we take dependency on this?
/cc @lachie83 @SteveLasker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of dependencies with permissive licenses is fine in the CNCF. It's copyleft licenses like MPL and GPL that you need to explicitly ask for an exception to be granted. Here is the doc from the CNCF stating that MIT is allowed - https://github.com/cncf/foundation/blob/master/allowed-third-party-license-policy.md#approved-licenses-for-allowlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - thanks for paying attention to this @sajayantony! It's not easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The treeview experience in the CLI really helps visualize the graph. Thanks @mnltejaswini for the great experience.
LGTM. |
* oras discover with tree output format Signed-off-by: Tejaswini Duggaraju <[email protected]> * oras discover with tree output format Signed-off-by: Tejaswini Duggaraju <[email protected]> * Apply artifact type filter only on the root node Signed-off-by: Tejaswini Duggaraju <[email protected]> Signed-off-by: Sajay Antony <[email protected]>
Add support for tree output to
oras discover
command. This output format traverses all the references and display them in a hierarchy tree structure.Fixes #295