Migrate to oras-go library #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Dolitsky <[email protected]>
Signed-off-by: Josh Dolitsky <[email protected]>
|
Note: I've also added commit c8ce737 to prep for a v0.12.0 release after this is merged |
deitch
approved these changes
May 4, 2021
There was a problem hiding this comment.
We should do this. Separating it out gives us a whole future path for doing things with the CLI at its own pace.
The lack of tests is a little disconcerting, but the reality is that we never had CLI tests anyways. Should we? Sure. Does this change it? Actually it makes it better, but adding a few very basic smoke tests.
We have an open question about the library name, which should be resolved first, then this should get merged in.
ndeloof
added a commit
to ndeloof/helm
that referenced
this pull request
May 7, 2021
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <[email protected]>
3 tasks
ndeloof
added a commit
to ndeloof/helm
that referenced
this pull request
May 25, 2021
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
added a commit
to ndeloof/helm
that referenced
this pull request
Jul 19, 2021
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <[email protected]>
tylerauerbeck
pushed a commit
to tylerauerbeck/helm
that referenced
this pull request
Aug 5, 2021
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <[email protected]>
tylerauerbeck
pushed a commit
to tylerauerbeck/helm
that referenced
this pull request
Aug 5, 2021
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <[email protected]>
zak905
pushed a commit
to zak905/helm
that referenced
this pull request
Jan 19, 2023
see oras-project/oras#265 Signed-off-by: Nicolas De Loof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git history has been migrated to the following new repositories:
This PR removes all code/docs that have been migrated to the above repos, and leaves behind only code related to the ORAS CLI.
CI/testing has been affected since the unit tests and acceptance tests are now in oras-go. Instead, I've added "make build-linux" and "oras version" to GHitHub actions to make sure the code at least builds. We should soon add some acceptance tests in this repo to make sure the CLI operates as expected (possibly a replacement for #257 )