Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use function instead of static map #220

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Feb 10, 2021

The multiwriter passed a map[string]content.Writer. The problem is that the thing that creates these writers sometimes doesn't know what writer it will use until later. This changes it to a func, so that it can determine it on the fly. The net result is the same, with some more flexibility.

Discussed on slack with @jdolitsky

I still have some work to do to be sure this is ready, but the initial view can get looked at.

@deitch deitch force-pushed the switch-multi-to-func branch 2 times, most recently from 70d7d07 to c66f4c4 Compare February 11, 2021 13:58
@deitch deitch changed the title [WIP] use function instead of static map use function instead of static map Feb 12, 2021
@deitch
Copy link
Contributor Author

deitch commented Feb 12, 2021

Removed [WIP]

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch force-pushed the switch-multi-to-func branch from c66f4c4 to 76a5d13 Compare February 12, 2021 09:17
@deitch
Copy link
Contributor Author

deitch commented Feb 12, 2021

And added a test for the new PassthroughMultiWriter

@deitch
Copy link
Contributor Author

deitch commented Feb 15, 2021

Fully ready for a review @jdolitsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants