Fix OCIStore inconsistent state after AddReference #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update descriptor in the nameMap as well as in index.Manifests. nameMap used in the ListReferences operation and should return actual descriptor.
distorhead
added a commit
to werf/werf
that referenced
this pull request
Jan 28, 2021
The bug is in the deislabs/oras: oras-project/oras#215
distorhead
added a commit
to werf/werf
that referenced
this pull request
Jan 28, 2021
The bug is in the deislabs/oras: oras-project/oras#215 Use fix from the fork for now: https://github.com/werf/oras/tree/v0.8.1+fix1
|
thank you. Is there any way to add a test for the inconsistent state to prevent in the future? |
|
Sure, I will add unit test for this case ASAP. |
jdolitsky
approved these changes
Feb 4, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update descriptor in the nameMap as well as in index.Manifests.
nameMap used in the ListReferences operation and should return actual descriptor.