Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty artifact #154

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Allow empty artifact #154

merged 3 commits into from
Mar 6, 2020

Conversation

shizhMSFT
Copy link
Contributor

Allow oras to push or pull empty artifact, which has no layers but a config.

CLI experience is shown as follows.

  • on push:
PS C:\> oras push shizhtest.azurecr.io/oras/empty:latest
Uploading empty artifact
Pushed shizhtest.azurecr.io/oras/empty:latest
Digest: sha256:bc4b23b58840b73e24d7be3ff6baa477a830999023af4c75c83ec4db6c86fc9a
  • on pull:
PS C:\> oras pull shizhtest.azurecr.io/oras/empty:latest
Downloaded empty artifact
Pulled shizhtest.azurecr.io/oras/empty:latest
Digest: sha256:bc4b23b58840b73e24d7be3ff6baa477a830999023af4c75c83ec4db6c86fc9a

Resolves #153

@shizhMSFT
Copy link
Contributor Author

/test

jdolitsky
jdolitsky approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shizhMSFT shizhMSFT merged commit 19a0d44 into master Mar 6, 2020
@shizhMSFT shizhMSFT deleted the shizh/empty branch March 6, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow ORAS to push / pull empty artifacts with config only
2 participants
@shizhMSFT @jdolitsky