Revert "bump(ci): update codecov gha to v4 (#1324)" #1333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fb3adab. Signed-off-by: Terry Howe <[email protected]>
TerryHowe
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
qweeah
as code owners
|
@TerryHowe Can we hold this PR from merging? We encountered consistent codecov upload failure in v3, which is also reproduced in this PR (see logs). We have already uploaded token to Github secrets so the main branch upload can pass. The remaining piece is that we need to add this Codecov token to dependabot secrets as is suggested in codecov/codecov-action#1292 (comment). Will do it tomorrow and that will fix the dependabot PR failure. |
|
@TerryHowe I've added the token to the dependabot and it works now. |
|
Please re-open the PR if you find anything wrong again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fb3adab.
What this PR does / why we need it:
github action broken. The codecov failure should succeed when this merges.
Which issue(s) this PR fixes
Related #1291