Allow overriding the ManifestDescriptor when pushing #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jzelinskie
suggested changes
Oct 11, 2019
ecordell
force-pushed
the
manifestdescriptor-override
branch
from
2566435 to
a41d6a9
Compare
jzelinskie
approved these changes
Oct 14, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR adds a new field to
PushOpt, and corresponding config functions, to allow giving an entire manifest descriptor to ORAS when pushing.Why
I've been experimenting with building small, static images using ORAS, while still making them appear as standard docker v2-2 images rather than OCI.
I found that I could do almost everything I needed to aside from overriding the ManifestDescriptor - which I needed to do to set the MediaType on the manifest (
image-specomits this field, but docker registry complains about it).See where I'm using this here: https://github.com/ecordell/bndlr/blob/master/pkg/bundle/bundle.go#L58-L79
Also open to feedback and suggestions if there are better approaches to what I'm doing. Thanks!