fix: Revert github actions coverage until fixed #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terry Howe <[email protected]>
TerryHowe
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
qweeah
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 83 83
Lines 4005 4005
=======================================
Hits 3284 3284
Misses 498 498
Partials 223 223 ☔ View full report in Codecov by Sentry. |
TerryHowe
changed the title
sajayantony
approved these changes
Mar 15, 2024
|
Actually, it's not caused by codecov GHA version update, it's a known transient failure on codcov service side. The original PR do passes the build, see logs. |
|
Interesting, what I said was not right. It's not a transient failure. Merging the PR will sign the squashed commit with an unkown GPG key, which makes the codecov v4 fail. So even if the PR build passes, the main branch build may still fail. |
|
Interesting. I did create an issue #1291 to update when there is a fix |
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
Signed-off-by: Terry Howe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It looks like there are problems with v4 coverage I was not aware off. Reverting for now.
codecov/codecov-action#1292