fix: correct e2e specs and CI check configuration #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <[email protected]>
qweeah
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
TerryHowe
as code owners
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1023 +/- ##
==========================================
+ Coverage 81.08% 81.21% +0.13%
==========================================
Files 57 57
Lines 2907 2907
==========================================
+ Hits 2357 2361 +4
+ Misses 376 373 -3
+ Partials 174 173 -1 |
|
I have validated the change here will prevent false positive result. See https://github.com/qweeah/oras/actions/runs/5572577038/jobs/10178767730#step:6:9075, the error will be returned if the e2e fails. |
qweeah
added a commit
to qweeah/oras
that referenced
this pull request
Jul 21, 2023
Signed-off-by: Billy Zha <[email protected]>
qweeah
added a commit
to qweeah/oras
that referenced
this pull request
Jul 21, 2023
Signed-off-by: Billy Zha <[email protected]>
shizhMSFT
pushed a commit
to shizhMSFT/oras
that referenced
this pull request
Aug 3, 2023
Signed-off-by: Billy Zha <[email protected]>
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1022
Please check the following list: