change tests

Signed-off-by: Billy Zha <[email protected]>

cmd/oras/internal/fileref/unix.go

@@ -24,10 +24,6 @@ import (
 
 // Parse parses file reference on unix.
 func Parse(reference string, defaultMediaType string) (filePath, mediaType string, err error) {
-	if reference == "" {
-		return "", "", nil
-	}
-
 	filePath = reference
 	mediaType = defaultMediaType
 	i := strings.LastIndex(reference, ":")

cmd/oras/internal/fileref/unix_test.go

@@ -68,7 +68,7 @@ func TestParse(t *testing.T) {
 		wantErr       bool
 	}{
 
-		{"no input", args{"", ""}, "", "", false},
+		{"no input", args{"", ""}, "", "", true},
 		{"empty file name and media type", args{":", ""}, "", "", true},
 		{"empty file name with media type", args{":a", "b"}, "", "", true},
 	}

cmd/oras/internal/fileref/windows.go

@@ -25,11 +25,6 @@ import (
 
 // Parse parses file reference on windows.
 func Parse(reference string, defaultMediaType string) (filePath, mediaType string, err error) {
-	if reference == "" {
-		// no input
-		return "", "", nil
-	}
-
 	filePath, mediaType = doParse(reference, defaultMediaType)
 	if filePath == "" {
 		return "", "", fmt.Errorf("found empty file path in %q", reference)

cmd/oras/internal/fileref/windows_test.go

@@ -82,7 +82,7 @@ func TestParse(t *testing.T) {
 		wantMediatype string
 		wantErr       bool
 	}{
-		{"no input", args{"", ""}, "", "", false},
+		{"no input", args{"", ""}, "", "", true},
 		{"empty file name", args{":", ""}, "", "", true},
 		{"reserved character1 in file name", args{"<", "a"}, "", "", true},
 		{"reserved character2 in file name", args{">", "a"}, "", "", true},

cmd/oras/pull.go

@@ -118,9 +118,12 @@ func runPull(opts pullOptions) error {
 	// Copy Options
 	copyOptions := oras.DefaultCopyOptions
 	copyOptions.Concurrency = opts.concurrency
-	configPath, configMediaType, err := fileref.Parse(opts.ManifestConfigRef, "")
-	if err != nil {
-		return err
+	var configPath, configMediaType string
+	if opts.ManifestConfigRef != "" {
+		configPath, configMediaType, err = fileref.Parse(opts.ManifestConfigRef, "")
+		if err != nil {
+			return err
+		}
 	}
 	if targetPlatform != nil {
 		copyOptions.WithTargetPlatform(targetPlatform)