-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update the registry matching pattern #79
Conversation
Awesome! You'll need to sign the DCO to contribute (not my rule, inherited because oras is a CNCF project I think) and then:
|
Fixed and updated |
Signed-off-by: Heck, Jerod <[email protected]>
Signed-off-by: Heck, Jerod <[email protected]>
Signed-off-by: Heck, Jerod <[email protected]>
Signed-off-by: Heck, Jerod <[email protected]>
Co-authored-by: Vanessasaurus <[email protected]> Signed-off-by: jhlmco <[email protected]>
Signed-off-by: Heck, Jerod <[email protected]>
Signed-off-by: Heck, Jerod <[email protected]>
Signed-off-by: Heck, Jerod <[email protected]>
@jhlmco you likely have a different version of black - make sure you are using |
Yeah, I created a virtual environment, installed everything, wired in pre-commit, and ran it. I get a ton of errors for mypi but nothing to do with the 2 line change I made. |
Would you like some help? |
@vsoch if it's a quick formatting fix that'd be great! |
Signed-off-by: vsoch <[email protected]>
This looks great! I'll try to remove my sign when I squash and merge so the commit credit is fully yours. Thanks for your patience with the linting! |
ohh that's super adorable!! I'm sold 😍 Please ping me if/when you have something to test. |
Totally! |
Small fix, closes issue 78