Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the registry matching pattern #79

Merged
merged 9 commits into from
Mar 4, 2023
Merged

fix: Update the registry matching pattern #79

merged 9 commits into from
Mar 4, 2023

Conversation

jhlmco
Copy link
Contributor

@jhlmco jhlmco commented Mar 2, 2023

Small fix, closes issue 78

@jhlmco jhlmco requested a review from SteveLasker as a code owner March 2, 2023 23:50
@vsoch
Copy link
Contributor

vsoch commented Mar 3, 2023

Awesome! You'll need to sign the DCO to contribute (not my rule, inherited because oras is a CNCF project I think) and then:

  • bump the version in oras/version.py
  • update the CHANGELOG.md with a note and the new version

@jhlmco
Copy link
Contributor Author

jhlmco commented Mar 3, 2023

Awesome! You'll need to sign the DCO to contribute (not my rule, inherited because oras is a CNCF project I think) and then:

Fixed and updated

CHANGELOG.md Outdated Show resolved Hide resolved
oras/provider.py Show resolved Hide resolved
jhlmco and others added 2 commits March 2, 2023 20:37
Co-authored-by: Vanessasaurus <[email protected]>
Signed-off-by: jhlmco <[email protected]>
Signed-off-by: Heck, Jerod <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
@vsoch
Copy link
Contributor

vsoch commented Mar 3, 2023

@jhlmco you likely have a different version of black - make sure you are using 23.1.0

@jhlmco
Copy link
Contributor Author

jhlmco commented Mar 3, 2023

@jhlmco you likely have a different version of black - make sure you are using 23.1.0

Yeah, I created a virtual environment, installed everything, wired in pre-commit, and ran it. I get a ton of errors for mypi but nothing to do with the 2 line change I made.

@vsoch
Copy link
Contributor

vsoch commented Mar 3, 2023

Would you like some help?

@jhlmco
Copy link
Contributor Author

jhlmco commented Mar 3, 2023

@vsoch if it's a quick formatting fix that'd be great!

Signed-off-by: vsoch <[email protected]>
@vsoch
Copy link
Contributor

vsoch commented Mar 4, 2023

This looks great! I'll try to remove my sign when I squash and merge so the commit credit is fully yours. Thanks for your patience with the linting!

@vsoch vsoch merged commit d17bb93 into oras-project:main Mar 4, 2023
@jhlmco
Copy link
Contributor Author

jhlmco commented Mar 4, 2023

@vsoch Awesome! Glad to help! Looking to leverage it in another opensource tool (shameless plug hoppr) as an option for bundling artifacts.

@vsoch
Copy link
Contributor

vsoch commented Mar 4, 2023

ohh that's super adorable!! I'm sold 😍 Please ping me if/when you have something to test.

@jhlmco
Copy link
Contributor Author

jhlmco commented Mar 4, 2023

Totally!

@jhlmco jhlmco deleted the fix-issue-78 branch March 6, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants