-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: join next link instead of append for pagination in get_tags #174
fix: join next link instead of append for pagination in get_tags #174
Conversation
d487eed
to
69ba7e8
Compare
This looks good - pending tests passing, would you please bump the version and update the CHANGELOG.md with the corresponding version and a note about the change? |
I can do that. I wasn't sure (didn't actually check) if that was part of the process. Coming soon. |
That's a good point! I can add a note to the readme about it. |
@vsoch , I think I need some guidance after all. I see this in the CHANGELOG.md
But the version in main is Do you expect me to add this PR as |
That means the release isn't done yet - so you can add an indentation under 0.2.26 with your change. We can do the release this time, so feel free to bump the version too. |
I have pushed a commit with updated CHANGELOG and version bumped but if you want to wait a bit. I can provide a PR to fix #167. |
Signed-off-by: Nate Faerber <[email protected]>
Signed-off-by: Nate Faerber <[email protected]>
1db4167
to
17f1a60
Compare
We can do that in a separate PR (and I'll hold off on the release if you want to do it to add it). Thanks @natefaerber ! |
Here that other PR: #176 |
Resolves #173
Some simple testing (see original issue for reproduction):
Note that an error will still occur when passing
N > 1000
but I'm not trying to add that guardrail here.