Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with .tar.gz upload - name needs .tar.gz in it #114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vsoch
Copy link
Contributor

@vsoch vsoch commented Nov 10, 2023

There is a bug with the title that, given it does not have .tar.gz with the oras-go client, it will not be extracted as such.

Signed-off-by: vsoch <[email protected]>
@vsoch vsoch requested a review from SteveLasker as a code owner November 10, 2023 21:44
@MichaelKopfMkf
Copy link
Contributor

I think this is not the desired behaviour.
The oras cli does not publish directories with a tar.gz file ending in the title.

I think it uses the layers annotation io.deis.oras.content.unpack to decide whether to unpack a layer or not.
the title is then used as target location for the unpacked tar.

I suggested to make oras-py also use this annotation here:
#170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants