-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support filtering on annotation with regex #259
support filtering on annotation with regex #259
Conversation
As annotation has the structure of map[string]string, my implementation of the filtering has 2 arguments: |
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
==========================================
- Coverage 70.57% 70.50% -0.08%
==========================================
Files 35 35
Lines 3055 3078 +23
==========================================
+ Hits 2156 2170 +14
- Misses 669 675 +6
- Partials 230 233 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of FilterAnnotation
, I am thinking if FilterPredecessors
might be more appropriate.
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: wangxiaoxuan273 [email protected]
Resolves issue #203